lkml.org 
[lkml]   [2008]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 08/15] scsi_host regression: fix scsi host leak
    2.6.25-stable review patch.  If anyone has any objections, please let us
    know.

    ------------------
    From: Mike Christie <michaelc@cs.wisc.edu>

    The patch is upstream as commit 3ed7897242b7efe977f3a8d06d4e5a4ebe28b10e

    A different backport is necessary because of the class_device to device
    conversion post 2.6.25.


    commit 9c7701088a61cc0cf8a6e1c68d1e74e3cc2ee0b7
    Author: Dave Young <hidave.darkstar@gmail.com>
    Date: Tue Jan 22 14:01:34 2008 +0800

    scsi: use class iteration api

    Isn't a correct replacement for the original hand rolled host
    lookup. The problem is that class_find_child would get a reference to
    the host's class device which is never released. Since the host class
    device holds a reference to the host gendev, the host can never be
    freed.

    In 2.6.25 we started using class_find_device, and this function also
    gets a reference to the device, so we end up with an extra ref
    and the host will not get released.

    This patch adds a class_put_device to balance the class_find_device()
    get. I kept the scsi_host_get in scsi_host_lookup, because the target
    layer is using scsi_host_lookup and it looks like it needs the SHOST_DEL
    check.

    Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
    Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


    ---
    drivers/scsi/hosts.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/drivers/scsi/hosts.c
    +++ b/drivers/scsi/hosts.c
    @@ -455,9 +455,10 @@ struct Scsi_Host *scsi_host_lookup(unsig
    struct Scsi_Host *shost = ERR_PTR(-ENXIO);

    cdev = class_find_child(&shost_class, &hostnum, __scsi_host_match);
    - if (cdev)
    + if (cdev) {
    shost = scsi_host_get(class_to_shost(cdev));
    -
    + class_device_put(cdev);
    + }
    return shost;
    }
    EXPORT_SYMBOL(scsi_host_lookup);
    --


    \
     
     \ /
      Last update: 2008-06-19 23:37    [W:0.021 / U:31.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site