Messages in this thread | | | Date | Thu, 19 Jun 2008 14:50:14 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH] x86-64: remove unnecessary ptregs call stubs |
| |
Ingo Molnar wrote: > * Jan Beulich <jbeulich@novell.com> wrote: > >> A few of the ptregs call stubs are superfluous these days - the called >> functions don't have a trailing 'struct pt_regs *' parameter anymore. > > applied to tip/x86/cleanups - thanks Jan.
Just want to point out that not having a pt_regs * argument is not necessarily sufficient for not needing a ptregs stub. Some code also accesses ptregs directly through the stack top from get_thread_info() and might assume a full one. That said I *think* it's ok for sigsuspend et.al. as in Jan's patch, but I haven't audited the complete code paths in question that they never do that.
Would be good to clarify that in the commit log.
-Andi
| |