lkml.org 
[lkml]   [2008]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86-64: remove unnecessary ptregs call stubs
Ingo Molnar wrote:
> * Jan Beulich <jbeulich@novell.com> wrote:
>
>> A few of the ptregs call stubs are superfluous these days - the called
>> functions don't have a trailing 'struct pt_regs *' parameter anymore.
>
> applied to tip/x86/cleanups - thanks Jan.

Just want to point out that not having a pt_regs * argument is not necessarily
sufficient for not needing a ptregs stub. Some code also accesses ptregs directly
through the stack top from get_thread_info() and might assume a full one. That said I *think*
it's ok for sigsuspend et.al. as in Jan's patch, but I haven't audited the complete code paths
in question that they never do that.

Would be good to clarify that in the commit log.

-Andi


\
 
 \ /
  Last update: 2008-06-19 14:53    [W:0.080 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site