Messages in this thread | | | Date | Thu, 19 Jun 2008 14:27:18 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] i386: fix vmalloc_sync_all() for Xen |
| |
* Jan Beulich <jbeulich@novell.com> wrote:
> >Given that the usermode PGDs will never need syncing, I think it would > >be better to use KERNEL_PGD_PTRS, and define > > > >#define sync_index(a) (((a) >> PMD_SHIFT) - KERNEL_PGD_BOUNDARY) > > > >for a massive 192 byte saving in bss. > > I was considering that, too, but didn't do so for simplicity's sake. > If I'll have to re-spin the patch, I may as well do it.
you could do it as a second add-on patch as well - or as a respun patch. Jeremy, is it now Acked-by you?
Ingo
| |