Messages in this thread | | | Date | Wed, 18 Jun 2008 12:30:06 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: more header fixes |
| |
* Vegard Nossum <vegard.nossum@gmail.com> wrote:
> Hi, > > Summary: Add missing include guards for some x86 headers.
applied to tip/x86/cleanups, thanks Vegard.
> This has only had the most rudimentary testing, but is hopefully > obviously correct. (That's just doomed to generate some sort of build > failure, isn't it?)
heh ;-)
> PS: I now have a pretty cool framework in Perl for parsing and > checking headers. And it can be used to transform them automatically > too. So if you want to standardize the guard format of all the headers > in one go, we have the means to do it quickly and efficiently...
very nice! I think the reference should be something like the unified include/asm-x86/processor.h.
could you try a run with that and put the result into a git tree for me to pull for review? I think we want to finetune that result and do a flag day for those cleanups, right after all the x86 topics went into v2.6.27.
Ingo
| |