lkml.org 
[lkml]   [2008]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] x86: Move PCI IO ECS code to x86/pci

* Robert Richter <robert.richter@amd.com> wrote:

> Ok, so what about shared code? Keep all this in separate files:
> amd_bus.c, (amd_bus_32.c), amd_bus_64.c, (amd_bus.h)?
>
> Is the strategy to avoid #ifdefs and instead use the flags in
> Makefiles? My intention was to coalesce the files. Maybe I was wrong
> here.

What you did is fine - first step is to move the variants as close to
each other as possible, in an as obvious and mechanic step as possible.

If anything breaks due to your patches then they were probably too
large, but lets be optimistic and try your current splitup first :)

Then we can start eliminating any leftover #ifdefs, step by step. Please
send very, very small patches for that (put them into a git tree on
kernel.org if there's more than say a dozen of them), we'll test them,
and if the changes break anything it's all bisectable to an individual
change.

Ingo


\
 
 \ /
  Last update: 2008-06-18 09:55    [W:0.047 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site