lkml.org 
[lkml]   [2008]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Latest Linus git: kernel/sched.c:1216: warning: ?init_hrtick? defined but not used

    * Kevin Winchester <kjwinchester@gmail.com> wrote:

    >> Subject: sched: fix defined-but-unused warning
    >> From: Rabin Vincent <rabin@rab.in>
    >> Date: Sun, 11 May 2008 05:55:33 +0530
    >>
    >> Fix this warning, which appears with !CONFIG_SMP:
    >> kernel/sched.c:1216: warning: `init_hrtick' defined but not used
    >>
    >> Signed-off-by: Rabin Vincent <rabin@rab.in>
    >> Signed-off-by: Ingo Molnar <mingo@elte.hu>
    >> ---
    >> kernel/sched.c | 2 ++
    >> 1 file changed, 2 insertions(+)
    >>
    >> Index: linux/kernel/sched.c
    >> ===================================================================
    >> --- linux.orig/kernel/sched.c
    >> +++ linux/kernel/sched.c
    >> @@ -1130,6 +1130,7 @@ static enum hrtimer_restart hrtick(struc
    >> return HRTIMER_NORESTART;
    >> }
    >> +#ifdef CONFIG_SMP
    >> static void hotplug_hrtick_disable(int cpu)
    >> {
    >> struct rq *rq = cpu_rq(cpu);
    >> @@ -1185,6 +1186,7 @@ static void init_hrtick(void)
    >> {
    >> hotcpu_notifier(hotplug_hrtick, 0);
    >> }
    >> +#endif /* CONFIG_SMP */
    >> static void init_rq_hrtick(struct rq *rq)
    >> {
    >
    > Did this ever make it to a pull request? I still see the warning with
    > latest git.

    it's queued up in tip/sched-devel at the moment:

    # sched-devel: 81d41d7: sched: fix defined-but-unused warning

    but you are right, we can do this in v2.6.26 - i have cherry-picked it
    over into the v2.6.26 queue of patches.

    Ingo


    \
     
     \ /
      Last update: 2008-06-17 10:41    [W:0.023 / U:32.620 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site