lkml.org 
[lkml]   [2008]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 06/15] MMC: Add platform data for S3C24XX MMC/SD driver
On Sat, Jun 14, 2008 at 06:22:20PM +0200, Pierre Ossman wrote:
> On Fri, 06 Jun 2008 16:51:23 +0100
> Ben Dooks <ben-linux@fluff.org> wrote:
>
> > This patch adds platform data support to the s3mci driver. This allows
> > flexible board-specific configuration of set_power, card detect and read only
> > pins.
> >
> > Signed-off-by: Ben Dooks <ben-linux@fluff.org>
> >
>
> Please see the changes in my #next branch where you can return -ENOSYS
> to indicate that you do not know the state of the read only pin.

thanks, fixed.

> > +
> > +static struct s3c24xx_mci_pdata s3cmci_def_pdata = {
> > + .gpio_detect = 0,
> > + .set_power = NULL,
> > + .ocr_avail = MMC_VDD_32_33,
> > };
>
> You probably want MMC_VDD_32_32 | MMC_VDD_33_34 here.

Ok, updated.

thanks,
--
Ben

Q: What's a light-year?
A: One-third less calories than a regular year.



\
 
 \ /
  Last update: 2008-06-18 01:23    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site