lkml.org 
[lkml]   [2008]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kernel parameter vmalloc size fix

* Dave Young <hidave.darkstar@gmail.com> wrote:

> booting kernel with vmalloc=[any size<=16m] will oops.
>
> It's due to the vm area hole.
>
> In include/asm-x86/pgtable_32.h:
> #define VMALLOC_OFFSET (8 * 1024 * 1024)
> #define VMALLOC_START (((unsigned long)high_memory + 2 * VMALLOC_OFFSET - 1) \
> & ~(VMALLOC_OFFSET - 1))
>
> BUG_ON in arch/x86/mm/init_32.c will be triggered:
> BUG_ON((unsigned long)high_memory > VMALLOC_START);
>
> Fixed by return -EINVAL for invalid parameter

hm. Why dont we instead add the size of the hole to the
__VMALLOC_RESERVE value instead? There's nothing inherently bad about
using vmalloc=16m. The VM area hole is really a kernel-internal
abstraction that should not be visible in the usage of the parameter.

Ingo


\
 
 \ /
  Last update: 2008-06-16 10:05    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site