lkml.org 
[lkml]   [2008]   [Jun]   [15]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSun, 15 Jun 2008 15:56:12 +0930
FromDavid Newall <>
SubjectRe: [PATCH 2/2] 8139too: different style cleanups
Németh Márton wrote:
>  #  define DPRINTK(fmt, args...) \
> -	printk(KERN_DEBUG "%s: " fmt, __FUNCTION__ , ## args)
> +	printk(KERN_DEBUG "%s: " fmt, __func__ , ## args)
> 

Why change __FUNCTION__ to __func__?  I don't even know where __func__
come from?  Assuming that it isn't totally broken, and I'll believe that
it isn't, then would it be compiler-specific?   __FUNCTION__ is standard
and that's more than enough reason to prefer that form to any
non-standard variation.


Yes to the following; no to all the rest:

> -#define RTL8139_CAPS	HAS_CHIP_XCVR|HAS_LNK_CHNG> +#define RTL8139_CAPS	(HAS_CHIP_XCVR|HAS_LNK_CHNG)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-06-15 08:29    [from the cache]
©2003-2008