lkml.org 
[lkml]   [2008]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 01/15] MMC: S3C24XX MMC/SD driver. From: Thomas Kleffel <>
    On Fri, 06 Jun 2008 16:51:18 +0100
    Ben Dooks <ben-linux@fluff.org> wrote:

    > +#include <linux/mmc/mmc.h>

    You don't need this anymore.

    > + //if(cmd->flags & MMC_RSP_MAYFAIL) debug_as_failure = 0;

    Please remove all the dead code.

    > + if (mrq->data->error == MMC_ERR_NONE) {

    And rebase against HEAD. MMC_ERR_* are long gone.

    Also, please test using the mmc_test driver available in HEAD. A proper
    driver should pass all those tests (or possibly mark a few as
    unsupported if the hardware is utterly incapable of handling those
    requests).

    Rgds
    Pierre
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2008-06-14 18:21    [W:4.059 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site