lkml.org 
[lkml]   [2008]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: use add_highpages_with_active_regions for high pages init

* Yinghai Lu <yhlu.kernel@gmail.com> wrote:

> use early_node_map to init high pages, so can remove page_is_ram and
> page_is_reserved_early in the big loop with add_one_highpage
>
> also remove the page_is_reserved_early that is not needed.

applied to tip/x86/mpparse for testing, thanks.

Andrew: mm/page_alloc.c modification.

two small nits:

checkpatch warned about:

> + for_each_active_range_index_in_nid(i, nid){

that should be ') {' (note the extra space).
another thing checkpatch noticed:

> +extern void add_one_highpage_init(struct page *, int, int);
> +void __init add_highpages_with_active_regions(int nid, unsigned long start_p$

we want externs in header files.

Ingo


\
 
 \ /
  Last update: 2008-06-14 10:27    [W:0.245 / U:1.348 seconds]
©2003-2014 Jasper Spaans. Advertise on this site