lkml.org 
[lkml]   [2008]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cputopology: Always define CPU topology information [5th try]
Ingo Molnar wrote:
>
> * Ben Hutchings <bhutchings@solarflare.com> wrote:
>
> > Not all architectures and configurations define CPU topology
> > information. This can result in an empty topology directory in sysfs,
> > and requires in-kernel users to protect all uses with #ifdef - see
> > <http://marc.info/?l=linux-netdev&m=120639033904472&w=2>.
> >
> > The documentation of CPU topology specifies what the defaults should
> > be if only partial information is available from the hardware. So we
> > can provide these defaults as a fallback.
> >
> > This patch:
> >
> > - Adds default definitions of the 4 topology macros to <linux/topology.h>
> > - Changes drivers/base/topology.c to use the topology macros unconditionally
> > - Updates documentation accordingly
>
> applied to tip/core/topology - thanks Ben.

Unfortunately you lost the first paragraph of the commit message, then
created a second commit (difference between 4th and 5th versions) with
your own commit message and me as the author. Maybe it's nitpicking but I
would prefer to have strictly accurate metadata in the commit log.

Ben.

--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.


\
 
 \ /
  Last update: 2008-06-13 12:37    [from the cache]
©2003-2011 Jasper Spaans