lkml.org 
[lkml]   [2008]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] cputopology: Always define CPU topology information [5th try]
    Ingo Molnar wrote:
    >
    > * Ben Hutchings <bhutchings@solarflare.com> wrote:
    >
    > > > > This patch:
    > > > >
    > > > > - Adds default definitions of the 4 topology macros to <linux/topology.h>
    > > > > - Changes drivers/base/topology.c to use the topology macros unconditionally
    > > > > - Updates documentation accordingly
    > > >
    > > > applied to tip/core/topology - thanks Ben.
    > >
    > > Unfortunately you lost the first paragraph of the commit message, then
    > > created a second commit (difference between 4th and 5th versions) with
    > > your own commit message and me as the author. Maybe it's nitpicking
    > > but I would prefer to have strictly accurate metadata in the commit
    > > log.
    >
    > that's OK, see the delta patch below, it's rather trivial. It's better
    > to do these small delta patches where each change stands on its own than
    > to review a more complex combo patch. (Suggest me any other commit
    > metadata for this delta if you prefer, we can still change it.)
    [...]

    The message should be:

    Revert first two hunks of "cputopology: Always define CPU topology information"
    which were redundant with "x86: cleanup early per cpu variables/accesses v4".

    Ben.

    --
    Ben Hutchings, Senior Software Engineer, Solarflare Communications
    Not speaking for my employer; that's the marketing department's job.


    \
     
     \ /
      Last update: 2008-06-13 17:41    [W:0.024 / U:215.572 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site