lkml.org 
[lkml]   [2008]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 09/18] ide-cd: fold cdrom_start_seek into ide_cd_do_request
    Date
    From
    Do what the compiler does anyway: inline a function that is used only once. This
    saves us the overhead of a function call and the function is small enough to be
    embedded in the callsite anyways.

    Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
    ---
    drivers/ide/ide-cd.c | 11 ++---------
    1 files changed, 2 insertions(+), 9 deletions(-)

    diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
    index abf9af2..b8c98e1 100644
    --- a/drivers/ide/ide-cd.c
    +++ b/drivers/ide/ide-cd.c
    @@ -778,14 +778,6 @@ static ide_startstop_t cdrom_start_seek_continuation(ide_drive_t *drive)
    return cdrom_transfer_packet_command(drive, rq, &cdrom_seek_intr);
    }

    -static void cdrom_start_seek(ide_drive_t *drive)
    -{
    - struct cdrom_info *info = drive->driver_data;
    -
    - info->dma = 0;
    - info->start_seek = jiffies;
    -}
    -
    /*
    * Fix up a possibly partially-processed request so that we can start it over
    * entirely, or even put it back on the request queue.
    @@ -1233,7 +1225,8 @@ static ide_startstop_t ide_cd_do_request(ide_drive_t *drive, struct request *rq,
    drive->dsc_overlap) {
    xferlen = 0;
    fn = cdrom_start_seek_continuation;
    - cdrom_start_seek(drive);
    + info->dma = 0;
    + info->start_seek = jiffies;
    } else {
    xferlen = 32768;
    fn = cdrom_start_rw_cont;
    --
    1.5.5.1


    \
     
     \ /
      Last update: 2008-06-12 08:51    [W:0.029 / U:10.316 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site