lkml.org 
[lkml]   [2008]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: CDC_PLAY_AUDIO check in cdrom_count_tracks() and other oddities
On Thu, Jun 12 2008, Tejun Heo wrote:
> Hello, Jens.
>
> I'm tracking down a bug where HAL doesn't mount media automatically.
> It turned out that CDROM_DISC_STATUS wasn't reporting correct disc
> type which was caused by CDC_PLAY_AUDIO check failure at the top of
> cdrom_count_tracks().
>
> I've went through MMC-3 but couldn't find anything which associates
> play audio capability with READ_TOC. READ_TOC was mandatory command,
> so according to MMC-3, there's no reason to avoid issuing READ_TOC on
> !CDC_PLAY_AUDIO. Is there something I don't know?

That check predates me :-)

I can't imagine drives NOT having READ_TOC, so I don't think it's a
problem to remove the depedency on CDC_PLAY_AUDIO.

--
Jens Axboe



\
 
 \ /
  Last update: 2008-06-12 20:51    [W:0.027 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site