lkml.org 
[lkml]   [2008]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/23] checkpatch: add a checkpatch warning for new uses of __initcall().
    Date
    From: Michael Ellerman <michael@ellerman.id.au>

    [apw@shadowen.org: generalise pattern and add tests]
    Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
    Signed-off-by: Andy Whitcroft <apw@shadowen.org>
    ---
    scripts/checkpatch.pl | 4 ++++
    1 files changed, 4 insertions(+), 0 deletions(-)

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index 5420db6..cf70f12 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -2108,6 +2108,10 @@ sub process {
    if ($line =~ /\bsimple_(strto.*?)\s*\(/) {
    WARN("consider using strict_$1 in preference to simple_$1\n" . $herecurr);
    }
    +# check for __initcall(), use device_initcall() explicitly please
    + if ($line =~ /^.\s*__initcall\s*\(/) {
    + WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
    + }

    # use of NR_CPUS is usually wrong
    # ignore definitions of NR_CPUS and usage to define arrays as likely right
    --
    1.5.6.rc0.140.ga9675


    \
     
     \ /
      Last update: 2008-06-12 14:13    [W:0.019 / U:30.816 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site