lkml.org 
[lkml]   [2008]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PATCH] ACPI patches for 2.6.26-rc5


> > 27 files changed, 255 insertions(+), 180 deletions(-)
>
> Hmm. I get very different statistics:
>
> 27 files changed, 434 insertions(+), 359 deletions(-)
>
> You seem to use "git diff -w" to ignore whitespace changes, which explains
> it, but please don't - it makes it harder to compare with expected
> results, and it hides some changes entirely.
>
> I do agree that using '-w' is often useful, but especially for the purpose
> of letting people know what changed it kind of avoids the point by hiding
> many things.

Yes, I've been using "-b" recently:

git diff -b -M --stat linus..$RELEASE

and if I remove the "-b", we match:

27 files changed, 434 insertions(+), 359 deletions(-)

I have a vague memory of having a good reason to cut over to "-b"
a while back and noting that in my pull request, but if you prefer
no -b, no problem.

thanks,
-Len


\
 
 \ /
  Last update: 2008-06-12 05:11    [W:0.049 / U:53.724 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site