Messages in this thread | | | Date | Wed, 11 Jun 2008 13:09:39 -0400 | From | Dave Jones <> | Subject | Re: [patch] x86: microcode: Cosmetic changes |
| |
On Tue, Jun 10, 2008 at 01:15:12PM +0200, Ben Castricum wrote: > @@ -805,6 +806,9 @@ static int __init microcode_init (void) > { > int error; > > + printk(KERN_INFO > + "IA-32 Microcode Update Driver: v" MICROCODE_VERSION " <tigran@aivazian.fsnet.co.uk>\n"); > + > error = microcode_dev_init(); > if (error) > return error; > @@ -825,9 +829,6 @@ static int __init microcode_init (void) > } > > register_hotcpu_notifier(&mc_cpu_notifier); > - > - printk(KERN_INFO > - "IA-32 Microcode Update Driver: v" MICROCODE_VERSION " <tigran@aivazian.fsnet.co.uk>\n"); > return 0;
By doing this before the registration of the sysdev, we'll now be printing this on machines that don't have the microcode update facility. Pointless spew, for no obvious gain imo.
[Why we go through so many hoops before we check if the CPU is capable is a mystery to me. It would make more sense to have that be the first thing that gets checked when this inits]
Dave
-- http://www.codemonkey.org.uk
| |