lkml.org 
[lkml]   [2008]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 2.6.26-rc5-mm1: uml link error
From
Date
> Agreed. In that case the SORT(CONSTRUCTORS) statement in
> arch/um/kernel/dyn.lds.S needs to be changed as well though (see my
> previous patch in this thread) or we get the linker error detailed
> in the original post.
>
> > And we could get away with some flag or something where we
> > call the constructors.
>
> The decision whether constructors should be called or not is made at
> configuratiom time - I don't see a variable fitting into this scheme.
> The only alternative I could imagine would be to introduce a hidden
> config symbol CONFIG_CTORS which would be auto-selected by all archs
> except for uml.
>
> > And a comment explaning why UML is different is also missing.
>
> Done. Here comes the modifed patch: applies on top of
> kernel-call-constructors.patch, together with the remove-sort-
> construct patch:

With both patches applied builds and boots fine. Thanks.

> --
> kernel: disable constructor calling for uml
>
> From: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
>
> Disable calling of constructor functions for uml as they are already
> called by the host run-time environment.
>
> Found-by: Miklos Szeredi <miklos@szeredi.hu>

I believe the usual form is "Reported-by:".

Thanks,
Miklos


\
 
 \ /
  Last update: 2008-06-11 14:43    [W:1.059 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site