Messages in this thread | | | Date | Tue, 10 Jun 2008 17:39:32 -0700 | From | "Andrew G. Morgan" <> | Subject | Re: [PATCH] bugfix: was Re: [ linus-git ] prctl(PR_SET_KEEPCAPS, ...) is broken for some configs, e.g. CONFIG_SECURITY_SELINUX |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Serge E. Hallyn wrote: + else + current->securebits &= + ~issecure_mask(SECURE_KEEP_CAPS);
| In these last two conditions, don't you need to set *rc_p?
| Oh, or my kernel tree may be out of date, as I seem to recall a recent | patch initializing error to 0 in sys_prctl(), so this wouldn't | technically be a problem? Still would seem correct...
Yes, update your kernel and you will find this defaults to zero. I thought about redundantly forcing it, but decided that it wasn't worth the pain of working around the 80-column challenged extra indenting. :-(
Cheers
Andrew -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFITx7E+bHCR3gb8jsRAulwAJ0U6TwsWMZRs6epQNNWs+f27UuUfgCdEGut 4x/mUDuIX6TvCVnip5sZWVk= =1PdZ -----END PGP SIGNATURE-----
| |