lkml.org 
[lkml]   [2008]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 0/4, v14] PCI, ACPI: Physical PCI slot objects
Date
On Monday, June 09, 2008 8:12 pm Kenji Kaneshige wrote:
> > drivers/pci/hotplug/pci_hotplug_core.c | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > Index: 20080610/drivers/pci/hotplug/pci_hotplug_core.c
> > ===================================================================
> > --- 20080610.orig/drivers/pci/hotplug/pci_hotplug_core.c
> > +++ 20080610/drivers/pci/hotplug/pci_hotplug_core.c
> > @@ -555,6 +555,7 @@ int pci_hp_register(struct hotplug_slot
> > {
> > int result;
> > struct pci_slot *pci_slot;
> > + struct hotplug_slot *tmp;
> >
> > if (slot == NULL)
> > return -ENODEV;
> > @@ -567,6 +568,21 @@ int pci_hp_register(struct hotplug_slot
> > }
> >
> > /*
> > + * Prevent registering multiple hotplug slots with the same name.
> > + */
> > + spin_lock(&pci_hotplug_slot_list_lock);
> > + list_for_each_entry(tmp, &pci_hotplug_slot_list, slot_list) {
> > + pci_slot = tmp->pci_slot;
> > + if (pci_slot->bus == bus && pci_slot->number == slot_nr)
> > + continue;
> > + if (!strcmp(tmp->name, slot->name)) {
> > + spin_unlock(&pci_hotplug_slot_list_lock);
> > + return -EEXIST;
> > + }
> > + }
> > + spin_unlock(&pci_hotplug_slot_list_lock);
> > +
> > + /*
> > * No problems if we call this interface from both ACPI_PCI_SLOT
> > * driver and call it here again. If we've already created the
> > * pci_slot, the interface will simply bump the refcount.
>
> Please note that I made this patch against linux-next with your
> latest three patches applied.

I looked this over and it seems like it's already handled in Alex's latest
patchset (v15); can you take a look and make sure, Kenji-san (see Alex's
latest mail to you too).

I just need acks from you and Kristen before pushing this...

Thanks,
Jesse


\
 
 \ /
  Last update: 2008-06-10 21:27    [W:0.089 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site