Messages in this thread | | | Date | Tue, 10 Jun 2008 09:24:50 -0700 | From | Greg KH <> | Subject | Re: [2.6 patch] always enable FW_LOADER unless EMBEDDED=y |
| |
On Tue, Jun 10, 2008 at 07:04:08PM +0300, Adrian Bunk wrote: > James Bottomley recently discovered that we have > {request,release}_firmware() dummies for the case of the actual > functions not being available and has a fix for the bug that was > actually causing build errors for built-in users with > CONFIG_FW_LOADER=m. > > But now missing selects on FW_LOADER are no longer visible at > compile-time at all and can become runtime problems. > > FW_LOADER is infrastructure with relatively small codesize we can > safely enable for everyone, and only for people who really need small > kernels (and can be expected to know what they are doing) it matters > being able to disable it. > > This patch therefore always sets FW_LOADER=y and allows users only to > disable it with EMBEDDED=y. > > As a bonus, we can then get rid of all "select FW_LOADER" plus the due > to it required "depends on HOTPLUG" which removes some complexity from > our Kconfig files.
Well, we can't get rid of that if EMBEDDED is set, right?
You sent this as an RFC before, I thought people said to just fix up all of the dependancies with drivers that needed FW_LOADER to be enabled, that would be easier, right?
thanks,
greg k-h
| |