lkml.org 
[lkml]   [2008]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] resend Removes PID_MAX_DEFAULT.
On Tue, 10 Jun 2008 13:50:26 +0600
"Rakib Mullick" <rakib.mullick@gmail.com> wrote:

> This removes use of PID_MAX_DEFAULT. please reply.

Hi,

can I ask why?
can you explain what is wrong with the original? To me it's a bit weird
to move this from a central location to 2 other places....


>
> Signed-off-by: Md. Rakib Hassan Mullick (rakib.mullick@gmail.com)
> ---
> diff -upr linux-2.6.25-vanilla/include/linux/threads.h
> linux-2.6.25/include/linux/threads.h
> --- linux-2.6.25-vanilla/include/linux/threads.h 2008-04-17
> 08:49:44.000000000 +0600
> +++ linux-2.6.25/include/linux/threads.h 2008-06-07
> 18:46:29.000000000 +0600 @@ -22,15 +22,10 @@
> #define MIN_THREADS_LEFT_FOR_ROOT 4
>
> /*
> - * This controls the default maximum pid allocated to a process
> - */
> -#define PID_MAX_DEFAULT (CONFIG_BASE_SMALL ? 0x1000 : 0x8000)
> -
> -/*
> * A maximum of 4 million PIDs should be enough for a while.
> * [NOTE: PID/TIDs are limited to 2^29 ~= 500+ million, see futex.h.]
> */
> #define PID_MAX_LIMIT (CONFIG_BASE_SMALL ? PAGE_SIZE * 8 : \
> - (sizeof(long) > 4 ? 4 * 1024 * 1024 : PID_MAX_DEFAULT))
> + (sizeof(long) > 4 ? 4 * 1024 * 1024 : (CONFIG_BASE_SMALL ?
> 0x1000 : 0x8000)))
>
> #endif
> diff -upr linux-2.6.25-vanilla/kernel/pid.c linux-2.6.25/kernel/pid.c
> --- linux-2.6.25-vanilla/kernel/pid.c 2008-04-17
> 08:49:44.000000000 +0600 +++ linux-2.6.25/kernel/pid.c
> 2008-06-07 18:46:25.000000000 +0600 @@ -42,7 +42,10 @@ static struct
> hlist_head *pid_hash; static int pidhash_shift;
> struct pid init_struct_pid = INIT_STRUCT_PID;
>
> -int pid_max = PID_MAX_DEFAULT;
> +/*
> + * This controls the default maximum pid allocated to a process
> + */
> +int pid_max = CONFIG_BASE_SMALL ? 0x1000 : 0x8000 ;
>
> #define RESERVED_PIDS 300
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/


--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org


\
 
 \ /
  Last update: 2008-06-10 17:15    [W:0.038 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site