lkml.org 
[lkml]   [2008]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: enable preemption in delay
On Wed 2008-05-28 09:01:06, Steven Rostedt wrote:
>
>
> On Sun, 25 May 2008, Pavel Machek wrote:
> > > + if (unlikely(cpu != smp_processor_id())) {
> > > + if (loops <= TSC_MIGRATE_COUNT)
> > > + break;
> > > + cpu = smp_processor_id();
> > > + rdtscl(bclock);
> > > + loops -= TSC_MIGRATE_COUNT;
> > > + } else {
> > > + rdtscl(now);
> > > + if ((now - bclock) >= loops)
> > > + break;
> > > + loops -= (now - bclock);
> > > + bclock = now;
> >
> > What happens with different cpus running on different frequencies...?
> > Cpufreq?
>
> It's not even protected with the old code.

Maybe, but it is simple to fix as long as preemption is disabled. When
you enable it, it becomes much harder.

Lets get that fixed.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2008-06-01 16:21    [W:0.100 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site