Messages in this thread | | | Date | Sun, 01 Jun 2008 13:29:39 +0300 | From | Pekka Enberg <> | Subject | Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB |
| |
On Sun, Jun 01, 2008 at 12:13:02PM +0300, Pekka J Enberg wrote: >> I mean, assuming the BUG_ON bits are bogus, then we should always pass the >> pointer to the allocator. I audited most of the callers and they all seem >> to be really just using kmalloc() for allocation anyway. >> >> What do you think?
Paul Mundt wrote: > Isn't this what my original patch did? ;-)
Oh, almost, you had this bit in ksize() of SLAB:
+ page = virt_to_head_page(objp); + if (unlikely(!PageSlab(page))) + return PAGE_SIZE << compound_order(page);
Did you actually need it for something?
Pekka
| |