Messages in this thread |  | | | Date | Sat, 10 May 2008 00:14:41 +0200 | | From | Sebastian Siewior <> | | Subject | Re: [PATCH] [ASYNC_TX] don't include <asm/> headers |
| |
* Dan Williams | 2008-05-09 11:55:25 [-0700]: >On Fri, May 9, 2008 at 1:39 AM, Sebastian Siewior <lkml@ml.breakpoint.cc> wrote: >> * Dan Williams | 2008-04-29 23:42:46 [-0700]: >> >> >> >Thanks, I'll push this out for testing in -next / -mm. >> I can't see this in current -next and I can't remember that I got an >> email from Andrew. >> > >Hi Sebastian, Hi Dan,
>Yes I had put this in the background for awhile due to other issues. No problem. If you queue this up for another two weeks than I have no problem with it. I just wanted to make sure that you did not lose it :)
>I fixed up a few merge conflicts so that it will apply against the >current tree; however, the patch causes these new warnings: > >include/asm/xor_32.h:513: warning: 'xor_block_pII_mmx' defined but not used >include/asm/xor_32.h:521: warning: 'xor_block_p5_mmx' defined but not used >include/asm/xor_32.h:853: warning: 'xor_block_pIII_sse' defined but not used >include/asm-generic/xor.h:680: warning: 'xor_block_8regs' defined but not used >include/asm-generic/xor.h:688: warning: 'xor_block_32regs' defined but not used >include/asm-generic/xor.h:696: warning: 'xor_block_8regs_p' defined but not used >include/asm-generic/xor.h:704: warning: 'xor_block_32regs_p' defined >but not used > >It is not immediately clear why? I'm not sure why I haven't seen this myself. crypto/xor.c is the only user of those defines but linux/raid/xor.h is also included by async_xor.c which does not use xor_block_pII_mmx & friends. The best thing would be probably _not_ to merge those two header files like I did but keep them separate. Maybe we could move this define directly into crypto/xor.c since it is the only user?
Sebastian
|  |