![]() | ||||||||||
Messages in this thread |
Hi Maciej, On Fri, 9 May 2008 21:27:04 +0100 (BST), Maciej W. Rozycki wrote: > Well, sorry, but I could only sense the lack of style in this piece of > code, which is why I tried to apply some. I agree, i2c-sibyte is very old code, and unmaintained, coding style is horrible. That's one more reason to not include random style cleanups in a patch doing functional changes, the improvement will hardly be visible. If you care about cleaning up the code of this driver - and I would appreciate that - please make a separate patch. > You are free to disagree and as > you have undertaken maintenance of this area I am going to respect it. And I thank you for that. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |||||||||
| Last update: 2008-05-09 22:43 [from the cache] ©2003-2008 | ||||||||||