Messages in this thread | | | Date | Fri, 9 May 2008 17:07:59 +0200 | From | Robert Richter <> | Subject | Re: [Cbe-oss-dev] [PATCH] Updated: Reworked Cell OProfile: SPU mutex lock fix |
| |
Please see my comments below.
-Roberta
On 30.04.08 13:35:12, Carl Love wrote:
[...]
> -int spu_sync_stop(void) > +void spu_sync_stop(void) > { > unsigned long flags = 0; > - int ret = spu_switch_event_unregister(&spu_active); > - if (ret) { > - printk(KERN_ERR "SPU_PROF: " > - "%s, line %d: spu_switch_event_unregister returned %d\n", > - __FUNCTION__, __LINE__, ret); > - goto out; > - } > + > + /* Ignoring the return value from the unregister > + * call. A failed return value simply says there > + * was no registered event. Hence there will not > + * be any calls to process a switch event that > + * could cause a problem. > + */ > + spu_switch_event_unregister(&spu_active);
Better to use this here, to show the return value is ignored:
(void)spu_switch_event_unregister(...)
> > spin_lock_irqsave(&cache_lock, flags); > - ret = release_cached_info(RELEASE_ALL); > + release_cached_info(RELEASE_ALL);
Dito.
> spin_unlock_irqrestore(&cache_lock, flags); > -out: > pr_debug("spu_sync_stop -- done.\n"); > - return ret; > + return; > } > > > Index: Cell_kernel_4_15_2008/arch/powerpc/oprofile/op_model_cell.c > =================================================================== > --- Cell_kernel_4_15_2008.orig/arch/powerpc/oprofile/op_model_cell.c > +++ Cell_kernel_4_15_2008/arch/powerpc/oprofile/op_model_cell.c > @@ -1191,15 +1191,15 @@ static int cell_sync_start(void) > if (spu_cycle_reset) > return spu_sync_start(); > else > - return DO_GENERIC_SYNC; > + return 0; > } > > -static int cell_sync_stop(void) > +static void cell_sync_stop(void) > { > if (spu_cycle_reset) > - return spu_sync_stop(); > - else > - return 1; > + spu_sync_stop();
Same here.
> + > + return; > } > > struct op_powerpc_model op_model_cell = {
[...]
-- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter@amd.com
| |