lkml.org 
[lkml]   [2008]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] mm: define default cpu_to_node
Paul Mundt wrote:
> On Thu, May 08, 2008 at 04:02:39PM -0700, Mike Travis wrote:
>> * Some architectures have CONFIG_NUMA=y but do not define a
>> default cpu_to_node macro. This provides the default in
>> asm-generic/topology.h but it relies on the fact that
>> cpu_to_node is a defined macro (and not an inline function).
>>
> NACK.. This isn't going to work anyways, cpu_to_node() is just where the
> first build error occurs. If you do this, then parent_node() is the next
> one to blow up, node_to_cpumask() after that, etc, etc. For now I've just
> stubbed the asm-generic/topology.h definitions in to asm-sh/topology.h.


Ok, Thanks! I was looking at that but without being able to compile it,
it was just a wild swing towards the fence... ;-) And your rationale makes
sense, if an arch really has numa topology then it should define what that is.

Cheers,
Mike



\
 
 \ /
  Last update: 2008-05-09 17:05    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site