Messages in this thread |  | | | Date | Fri, 9 May 2008 07:44:34 -0700 (PDT) | | From | Linus Torvalds <> | | Subject | Re: [PATCH 3/3] module: don't ignore vermagic string if module doesn't have modversions | |
On Fri, 9 May 2008, Rusty Russell wrote:
>
> We should only ignore the start of the vermagic string if the module
> actually *has* crcs to check. Rather than (say) having an
> entertaining hissy fit and creating a config option to work around the
> buggy code.
Btw, this makes the two vesions of "same_magic()" be basically the same
(since without MODVERSIONS, has_crcs *should* always be zero). Maybe we
should make it just one version, to simplify logic?
Linus
|  |