![]() | |||||||||||||
Messages in this thread |
On Thu, 08 May 2008 17:02:44 -0700, Harvey Harrison <harvey.harrison@gmail.com> wrote: > On Fri, 2008-05-09 at 09:50 +1000, Paul Mackerras wrote: > > I think the best solution is to make a new sysfs_maybe_create_file() > > which isn't marked must_check, and then move suitable callers (such as > > radeonfb) over to that. That will make it obvious in the callers that > > the file creation isn't guaranteed. Either that... > > Or just a a flag parameter to the existing one that says whether failure > is allowed or not. In a case that fails, a WARN_ON can be printed from > the common create_file rather than putting printks all over the kernel. ...or that. But the core should still warn about duplicate files in all cases, since that indicates a bug. (And that will catch the problems we found before; IIRC a core warning didn't exist back then.) > > This would also document which files are necessary vs. optional. Shouldn't that rather go into Documentation/ABI/, so that people can easily find out what they may rely on? | ||||||||||||
| Last update: 2008-05-09 07:37 [W:0.892 / U:0.150 seconds] ©2003-2008 Jasper Spaans | |||||||||||||