lkml.org 
[lkml]   [2008]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] call_usermodehelper_setup() should use GFP_KERNEL
On Thu, 08 May 2008 16:31:29 +0900 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> > KOSAKI Motohiro wrote:
> > > Now, call_usermodehelper_setup() use GFP_ATOMIC.
> > > but it is slighly odd.
> > > because call_usermodehelper() is always called process context.
> > >
> >
> > Are you sure? I found the following call chain:
> >
> > static irqreturn_t power_handler(int irq, void *dev_id)
> > ->orderly_poweroff(true);
> > ->call_usermodehelper_setup()
>
> sorry, you are right.
> I'll make patch again.

How many times do we have to make this mistake :(

Only the caller knows what allocation mode the callee can use.
call_usermodehelper_setup() should be extended to take a gfp_t argument.



\
 
 \ /
  Last update: 2008-05-08 10:33    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site