Messages in this thread | | | Date | Fri, 9 May 2008 01:17:21 +0100 (BST) | From | "Maciej W. Rozycki" <> | Subject | Re: [RFC][PATCH 4/4] RTC: SMBus support for the M41T80, etc. driver |
| |
On Thu, 8 May 2008, Atsushi Nemoto wrote:
> For write transfer, you must use only one i2c_msg. If two i2c_msg > were used, the slave address is inserted between register number and > first data. This chip cannot accept such sequence.
Correct, thank you for pointing it out -- verified with the datasheet. I will send an updated patch separately taking other suggestions into account as well.
> On success, m41t80_i2c_transfer() returns positive value, but > m41t80_transfer() should return 0.
I think the check should be for values below zero as originally instead. Thanks for the point again.
Maciej
| |