Messages in this thread Patch in this message |  | | | Date | Thu, 08 May 2008 15:41:27 +0900 | | From | KOSAKI Motohiro <> | | Subject | [PATCH] call_usermodehelper_setup() should use GFP_KERNEL |
Now, call_usermodehelper_setup() use GFP_ATOMIC.
but it is slighly odd.
because call_usermodehelper() is always called process context.
GFP_KERNEL is robust and better.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
CC: "Paul Menage" <menage@google.com>
CC: Li Zefan <lizf@cn.fujitsu.com>
CC: Jeremy Fitzhardinge <jeremy@xensource.com>
CC: Andi Kleen <ak@suse.de>
CC: Rusty Russell <rusty@rustcorp.com.au>
---
kernel/kmod.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/kernel/kmod.c
===================================================================
--- a/kernel/kmod.c 2008-04-29 17:37:41.000000000 +0900
+++ b/kernel/kmod.c 2008-05-06 20:20:02.000000000 +0900
@@ -360,7 +360,7 @@ struct subprocess_info *call_usermodehel
char **argv, char **envp)
{
struct subprocess_info *sub_info;
- sub_info = kzalloc(sizeof(struct subprocess_info), GFP_ATOMIC);
+ sub_info = kzalloc(sizeof(struct subprocess_info), GFP_KERNEL);
if (!sub_info)
goto out;
|  |