Messages in this thread | | | Date | Thu, 8 May 2008 12:43:14 -0700 | From | Greg KH <> | Subject | Re: [patch 00/16] Linux 2.6.25 -stable review |
| |
On Thu, May 08, 2008 at 03:16:28PM -0400, Len Brown wrote: > On Thursday 08 May 2008, Willy Tarreau wrote: > > On Thu, May 08, 2008 at 11:22:33AM -0700, Greg KH wrote: > > > On Thu, May 08, 2008 at 08:13:42PM +0200, Willy Tarreau wrote: > > > > On Thu, May 08, 2008 at 10:41:22AM -0700, Greg KH wrote: > > > > > This is the start of the stable review cycle for the 2.6.25.2 release. > > > > > There are 16 patches in this series, all will be posted as a response to > > > > > this one. If anyone has any issues with these being applied, please let > > > > > us know. If anyone is a maintainer of the proper subsystem, and wants > > > > > to add a Signed-off-by: line to the patch, please respond with it. > > > > > > > > Greg, shouldn't we also queue this one (may be in a later version) ? It's > > > > in mainline. > > > > > > What problem does it solve? > > > > from what I see in the code, currently acpi_power_get_state() will return > > 0 when setting resource to NULL, and some callers (eg: acpi_power_on()) > > will happily dereference resource if acpi_power_get_state() returns 0. So > > I guess there are circumstances where we can oops. > > > > > Does Len want it in -stable? > > > > I simply forgot to ask. I'm CCing him. > > This patch is correct. > > Go ahead and apply it -- it won't hurt anything. > I don't think it will help anything in real-life either, though.
Ok, because of that, I'll not apply it, we want patches that actually fix reported problems.
thanks,
greg k-h
| |