Messages in this thread | | | Date | Thu, 08 May 2008 09:44:43 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86: introduce a new Linux defined feature flag for PAT support |
| |
Ingo Molnar wrote: > * Thomas Gleixner <tglx@linutronix.de> wrote: > >> Subject: x86: cleanup PAT cpu validation >> From: Thomas Gleixner <tglx@linutronix.de> >> Date: Thu, 08 May 2008 09:18:43 +0200 >> >> Move the scattered checks for PAT support to a single function. Its >> moved to addon_cpuid_features.c as this file is shared between 32 and >> 64 bit. > > thanks Thomas, i have applied your cleanup patch - looks good here too > and it booted fine on a few boxes. > > (i did a small cleanup: changed the define to static const int) > > Peter, what are your plans for a more general cleanup and 32-bit/64-bit > unification for the x86 CPU detection code - do you have any specific > ideas already? I suspect we want it all to end up unified under > arch/x86/kernel/cpu/, by moving the relevant bits of > arch/x86/kernel/setup_64.c there, right? It is no small task for sure. >
Yes, that's the plan, and no, it's not a small task.
-hpa
| |