lkml.org 
[lkml]   [2008]   [May]   [7]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 7 May 2008 19:24:35 -0700 (PDT)
FromLinus Torvalds <>
SubjectRe: [PATCH] x86: introduce a new Linux defined feature flag for PAT support

On Wed, 7 May 2008, H. Peter Anvin wrote:
> 
> Indeed it wasn't, and at least I have no interest of maintaining what is in
> effect an in-kernel version of x86info(1).

Umm. We already do, since we effectively ignore what the actual hardware 
says, and replace it with our own version.

> *Certainly* I don't want anything like this crap:
> 
> > -    if (cpu_has_pat)
> > +    if (cpu_has_pat && cpu_has_pat_good)

This in fact is likely the best part of it.

Because that at least guarantees that we never say we have a good PAT when 
the hardware doesn't even report it.

As it is, we seem to just blindly override hardware. It may be correct for 
all the models we override, but still..

		Linus


\
 
 \ /
  Last update: 2008-05-08 04:27    [from the cache]
©2003-2008