lkml.org 
[lkml]   [2008]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08 of 11] anon-vma-rwsem


On Thu, 8 May 2008, Andrea Arcangeli wrote:

> Hi Andrew,
>
> On Wed, May 07, 2008 at 03:59:14PM -0700, Andrew Morton wrote:
> > CPU0: CPU1:
> >
> > spin_lock(global_lock)
> > spin_lock(a->lock); spin_lock(b->lock);
> ================== mmu_notifier_register()

If mmy_notifier_register() takes the global lock, it cannot happen here.
It will be blocked (by CPU0), so there's no way it can then cause an ABBA
deadlock. It will be released when CPU0 has taken *all* the locks it
needed to take.

> What we can do is to replace the mm_lock with a
> spin_lock(&global_lock) only if all places that takes i_mmap_lock

NO!

You replace mm_lock() with the sequence that Andrew gave you (and I
described):

spin_lock(&global_lock)
.. get all locks UNORDERED ..
spin_unlock(&global_lock)

and you're now done. You have your "mm_lock()" (which still needs to be
renamed - it should be a "mmu_notifier_lock()" or something like that),
but you don't need the insane sorting. At most you apparently need a way
to recognize duplicates (so that you don't deadlock on yourself), which
looks like a simple bit-per-vma.

The global lock doesn't protect any data structures itself - it just
protects two of these mm_lock() functions from ABBA'ing on each other!

Linus



\
 
 \ /
  Last update: 2008-05-08 03:07    [W:0.131 / U:0.956 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site