Messages in this thread | | | Date | Thu, 8 May 2008 00:58:25 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: 2.6.26, PAT and AMD family 6 |
| |
On Thu, 8 May 2008, Pavel Machek wrote: > > Actually no, that's not a good reason to yell at _him_.
I'm glad, that we can agree on this.
> But it is _perfectly valid_ reason to yell at whoever commited that > to x86 tree, given that: > > 1) it has empty changelog (come on, "review" a patch and not notice > that changelog is empty?!)
Granted as I said before.
> 2) HPA said it was bad idea
Interpretation.
> 3) copy&paste code remained in the patch
Yes, it should have been done better.
So we made mistakes, but is this a justification for magnifying that to be the major contribution to the end of the universe ?
Definitely not.
I have no problem to admit a mistake, but I vehemently fight the way how such incidents are artificially exxagerated in the recent past.
I personally have broad enough shoulders to cope with the fact that bashing on x86 maintainers and trying to play them out against each other is currently en vogue.
But I have no understanding at all for the snotty way how valuable contributors are treated even when the responsibility of the actual merging of their imperfect patch is out of their scope.
Thanks,
tglx
| |