lkml.org 
[lkml]   [2008]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.26, PAT and AMD family 6
On Wed, May 7, 2008 at 3:39 PM, Pavel Machek <pavel@suse.cz> wrote:
> On Wed 2008-05-07 15:23:46, Yinghai Lu wrote:
> > > 2) HPA said it was bad idea
> >
> > hpa said white list is not a good idea.
>
> And guess what your patch is doing?
>
>
> + switch (c->x86_vendor) {
> + case X86_VENDOR_AMD:
> + if (c->x86 >= 0xf && c->x86 <= 0x11)
> + set_cpu_cap(c, X86_FEATURE_PAT);
> + break;
> + case X86_VENDOR_INTEL:
> + if (c->x86 == 0xF || (c->x86 == 6 && c->x86_model >=
> 15))
> + set_cpu_cap(c, X86_FEATURE_PAT);
> + break;
> + }
>
> Seems like a whitelist to me. Will break with future CPUs.

again, i only increased the whitelist a little bit to support AMD
opteron Rev E, Rev F and Fam10h that I could access.

the code handle future cpus should reach the kernel list before SW
developer could get system....

YH


\
 
 \ /
  Last update: 2008-05-08 00:47    [W:0.309 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site