Messages in this thread | | | Date | Thu, 8 May 2008 00:08:23 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: 2.6.26, PAT and AMD family 6 |
| |
On Thu, 8 May 2008, Adrian Bunk wrote: > > > > Yinghai missed to add it to the other place and he is hardly to blame > > for that. This code is messy and thats not his fault. It will be > > cleaned up, but that's not an simple taks to do. If you think you can > > do it without breaking tons of systems, you're welcome. > > It actually is completely his fault.
No it is not.
1) this code is messy to begin with
2) we accepted the change as is
> His commit ***added*** the three copies of the same code.
And you are not able to ******look******* over the brim of your tea cup and accept that one of them is 64 bit and the others are a tribute to the not yet distangled shit. There would have been a cleaner and better way to solve this, but there is always a better and cleaner way to do things.
Why dont you send a cleanup patch which fixes the three copies problem instead of spending your time with writing up ivory tower pieces of wisdom ?
Thanks,
tglx
| |