lkml.org 
[lkml]   [2008]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.26, PAT and AMD family 6
    On Wed, May 07, 2008 at 11:41:04PM +0200, Thomas Gleixner wrote:
    > On Wed, 7 May 2008, Rene Herman wrote:
    > > On 07-05-08 22:52, Thomas Gleixner wrote:
    >...
    > > > > And this patch (by the author of the code himself) is the first time where
    > > > > it breaks.
    > > >
    > > > Very interesting analysis. What broke ? This CPU was never in the set
    > > > of supported ones at all.
    > >
    > > You misunderstood. Yinghai's patch only changed one of the code sites
    > > and not the others, which (if I understood right) is the breakage
    > > Adrian was reffering to.
    >
    > I know exactly what he was referring to. So what's the problem ?
    >
    > Yinghai missed to add it to the other place and he is hardly to blame
    > for that. This code is messy and thats not his fault. It will be
    > cleaned up, but that's not an simple taks to do. If you think you can
    > do it without breaking tons of systems, you're welcome.

    It actually is completely his fault.

    His commit ***added*** the three copies of the same code.

    And Pavel did complain about it when it was sent to linux-kernel.

    >...
    > Thanks,
    >
    > tglx

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed



    \
     
     \ /
      Last update: 2008-05-07 23:51    [W:0.031 / U:30.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site