lkml.org 
[lkml]   [2008]   [May]   [7]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
FromJohannes Weiner <>
SubjectRe: [patch 1/3] Rename WARN() to WARNING() to clear the namespace
DateWed, 07 May 2008 14:46:53 +0200
Hi Arjan,

Arjan van de Ven <arjan@infradead.org> writes:

> Subject: Rename WARN() to WARNING() to clear the namespace
> From: Arjan van de Ven <arjan@linux.intel.com>
>
> We want to use WARN() as a variant of WARN_ON(), however
> a few drivers are using WARN() internally. This patch renames
> these to WARNING() to avoid the namespace clash.
> A few cases were defining but not using the thing, for those
> cases I just deleted the definition.

It always bugged me that there is no WARN() that behaves similar to
BUG().

What do you think of making WARN() just emit the warning
unconditionally?

And maybe add the possibility to emit a text as well on both WARN() and
BUG()?  BUG("my kitten was hit by page %p!\n", page);

	Hannes


\
 
 \ /
  Last update: 2008-05-07 14:48    [from the cache]
©2003-2008