lkml.org 
[lkml]   [2008]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [-mm][PATCH 3/5] change function prototype of shrink_zone()
Hi

> > + sc->nr_reclaimed += nr_reclaimed;
> > throttle_vm_writeout(sc->gfp_mask);
> > - return nr_reclaimed;
> > + return 0;
> > }
>
> I am not sure this is right.
> I might be wrong if this patch is depended on another patch.
>
> As I see, shrink_zone always return 0 in your patch.

Yeah, this patch is just preparetion change of [4/5].
I use EAGAIN at [4/5].


> If it is right, I think that return value is useless. It is better
> that we change function return type to "void"
> Also, we have to change functions that call shrink_zone properly. ex)
> balance_pgdat, __zone_reclaim
> That functions still use number of shrink_zone's reclaim page

this patch is not intent by solo usage.
just intent to bisect friendly.
thus, We need implement that following patch use freature only.

Thanks!


\
 
 \ /
  Last update: 2008-05-05 10:33    [W:1.060 / U:0.960 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site