[lkml]   [2008]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [patch] irda: fix !PNP support in drivers/net/irda/nsc-ircc.c
    From: Ingo Molnar <>
    Date: Mon, 5 May 2008 09:58:23 +0200

    > i just used the existing precedent of doing the #ifdef: it's not _that_
    > bad as it surrounds a single function most of the time so it's rather
    > apparent what is happening - and that is what is done in some other
    > drivers as well.
    > btw., when i fixed this i almost implemented it the way that you
    > suggested, but there's also a code size argument to when the suspend
    > callbacks are not used: the extra dummy function takes up text space,
    > and people turn off PNP when they build some specialized thing and try
    > to reduce the size of the kernel.
    > but in any case, i have no strong feelings in either direction.

    The existing practice is ugly :-)

    But I see arguments for either side, just like you.

    Meanwhile let's fix this build error, I'll toss your patches
    into my net-2.6 tree.


     \ /
      Last update: 2008-05-05 10:05    [W:0.018 / U:9.652 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site