Messages in this thread | | | Date | Mon, 5 May 2008 13:18:30 +0800 | From | "Dave Young" <> | Subject | Re: [PATCH -mm] __ratelimit rewrite |
| |
On Mon, May 5, 2008 at 10:52 AM, Joe Perches <joe@perches.com> wrote: > > On Mon, 2008-05-05 at 10:58 +0800, Dave Young wrote: > > On Mon, May 5, 2008 at 10:25 AM, Joe Perches <joe@perches.com> wrote: > > > On Mon, 2008-05-05 at 09:37 +0800, Dave Young wrote: > > > > > I think your changes should then be done in > > > > > printk.h not creating a new ratelimit.h. > > > > IMO ratelimit is not just for printk use now, so a standalone head > > > > file is necessary. > > > What other uses would ratelimit have? > > ratelimit is a general function, another user of it is > > WARN_ON_RATELIMIT in this patch. It could have other usage in future. > > You put WARN_ON_RATELIMIT in bug.h right? > WARN_ON in bug.h is a printk
Yes, warn is indeed printk, but it's not equal to printk.
> > printk.h should #include <asm/bug.h> > kernel.h should not include that file. > > What non print related function could be served by ratelimit?
You can do some other handling except printk in ratelimit logic.
After searching the code, I guess DCCP-Sync ratelimit can use this feature. David, am I right?
BTW, most of printk_ratelimit users should use their own ratelimit_state, maybe I should do the replace work as a patch series.
| |