| | Date | Mon, 5 May 2008 07:11:23 -0400 | | From | Christoph Hellwig <> | | Subject | Re: [patch 15/15] vfs: splice remove_suid() cleanup |
| |
On Mon, May 05, 2008 at 11:54:56AM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi <mszeredi@suse.cz> > > generic_file_splice_write() duplicates remove_suid() just because it > doesn't hold i_mutex. But it grabs i_mutex inside splice_from_pipe() > anyway, so this is rather pointless. > > Move locking to generic_file_splice_write() and call remove_suid() and > __splice_from_pipe() instead.
Looks good to me. I wonder whether we should kill splice_from_pipe entirely and always leave the locking to the caller.
|