lkml.org 
[lkml]   [2008]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 03/15] cgroup: dont call vfs_mkdir
    On Mon, May 05, 2008 at 11:54:44AM +0200, Miklos Szeredi wrote:
    > From: Miklos Szeredi <mszeredi@suse.cz>
    >
    > cgroup_clone() calls vfs_mkdir() to create a directory in the cgroup
    > filesystem. Replace with explicit call to cgroup_mkdir() and
    > fsnotify_mkdir().
    >
    > This is equivalent, except that the following functions are not called
    > before cgroup_mkdir():
    >
    > - may_create()
    > - security_inode_mkdir()
    > - DQUOT_INIT()
    >
    > Permission to clone the cgroup has already been checked in
    > copy_namespaces() (requiring CAP_SYS_ADMIN). Additional file system
    > related capability checks are inappropriate and confusing.
    >
    > The quota check is unnecessary, as quotas don't make any sense for
    > this filesystem.

    Looks correct but I don't think it's a good idea. Spreading more logic
    into filesystems without a good reason is rarely a good idea.



    \
     
     \ /
      Last update: 2008-05-05 13:05    [W:0.044 / U:0.956 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site