lkml.org 
[lkml]   [2008]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [POWERPC] Fix of_i2c include for module compilation
Jochen Friedrich writes:

> -#ifdef CONFIG_OF_I2C
> +#if defined(CONFIG_OF_I2C) || defined(CONFIG_OF_I2C_MODULE)
>
> void of_register_i2c_devices(struct i2c_adapter *adap,
> struct device_node *adap_node);

Why do we have that ifdef there at all? There's only that one
external declaration within it, so the #ifdef and #endif could just be
removed. If the ifdef hadn't been there in the first place we
wouldn't have had this problem.

Paul.


\
 
 \ /
  Last update: 2008-05-05 06:29    [from the cache]
©2003-2011 Jasper Spaans