Messages in this thread |  | | | Date | Sun, 04 May 2008 10:20:35 +0200 | | From | Michal Simek <> | | Subject | Re: [PATCH 1/2] OF: Fix coding style violation in of_device.c and of_platform.c |
Hi Arnd,
this is question to powerpc guys not to me. I haven't tried to compiled but I
think dcr.h is important header for powerpc.
I only fixed problem for Microblaze because we don't have these headers.
M
>>
>> #include <asm/errno.h>
>> +
>> +#ifdef CONFIG_PPC_PSERIES
>> #include <asm/dcr.h>
>> +#endif
>>
>
> The patch looks basically good, but we normally try to not have an #include
> inside of #ifdef. If the file builds without this #include, maybe you should
> better leave it out entirely? Same for the ppc-pci.h in the other file.
>
> Arnd <><
>
|  |